fix: rate limit factory validation, dynamic Retry-After, fractional refill test, schema accuracy#107
Merged
intel352 merged 2 commits intofix/auth-rate-limitingfrom Feb 23, 2026
Merged
Conversation
8 tasks
…al refill test, fix schema description Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add strict per-IP rate limiting to auth endpoints
fix: rate limit factory validation, dynamic Retry-After, fractional refill test, schema accuracy
Feb 23, 2026
intel352
added a commit
that referenced
this pull request
Feb 23, 2026
* security: add algorithm pinning tests for JWT confusion attacks (closes #95) Verified that all JWT validation paths in JWTAuthModule already enforce HS256 via both type assertion (*jwt.SigningMethodHMAC) and explicit algorithm check (token.Method.Alg() != jwt.SigningMethodHS256.Alg()). Added tests to module/jwt_auth_test.go that explicitly confirm tokens signed with HS384 or HS512 are rejected by: - Authenticate() — the AuthProvider interface method - handleRefresh via Handle() — the /auth/refresh endpoint - extractUserFromRequest via Handle() — all protected endpoints The api package (middleware.go, auth_handler.go) already had equivalent algorithm rejection tests in auth_handler_test.go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: document 10+ undocumented module types in DOCUMENTATION.md (closes #66) Adds detailed documentation for audit logging, license.validator, platform.provider/resource/context, observability.otel, step.jq, AI pipeline steps (ai_complete, ai_classify, ai_extract), CI/CD steps (docker_build, docker_push, docker_run, scan_sast, scan_container, scan_deps, artifact_push, artifact_pull), and the admincore plugin. Each entry includes config field tables with types and defaults, plus a minimal YAML example. Summary tables in the module type index are also updated with the new Infrastructure and CI/CD Step categories. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * security: add strict per-IP rate limiting to auth endpoints (closes #94) - Add dedicated rate-limit middleware modules for login (10/min) and register (5/hour) in admin/config.yaml, replacing the shared global limiter that allowed 120 req/min on sensitive auth endpoints - Extend RateLimitMiddleware to support fractional rates via float64 token buckets, enabling hourly rate configs without precision loss - Add NewRateLimitMiddlewareWithHourlyRate constructor and factory support for requestsPerHour config key - Add requestsPerHour field to the http.middleware.ratelimit schema - Add tests for hourly rate middleware and per-hour factory config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: rate limit factory validation, dynamic Retry-After, fractional refill test, schema accuracy (#107) * Initial plan * fix: validate rate limit config values, dynamic Retry-After, fractional refill test, fix schema description Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four issues identified in review of the per-IP rate limiting PR:
rateLimitMiddlewareFactorysilently accepted zero/negative config values, causing permanent rate-limiting or immediate rejectionRetry-Afterwas hardcoded to60regardless of the configured rate (wrong by orders of magnitude for hourly limiters)burstSizeschema description was semantically incorrectChanges
plugins/http/modules.gorequestsPerHour,requestsPerMinute,burstSize) with> 0; invalid values fall back to defaultsmodule/http_middleware.goRetry-Afterdynamically:ceil(60 / ratePerMinute)secondsmath,strconvimportsplugins/http/schemas.goburstSizedescription: "Maximum number of tokens in the bucket; determines how many requests can burst when the bucket is full"module/http_middleware_test.goTestNewRateLimitMiddlewareWithHourlyRate_FractionalRefill: exhausts burst, sleeps exactly one token-refill period, asserts exactly one additional request passes and the next is rejectedTestRateLimitMiddleware_RetryAfterHeader: expected value"60"→"1"(correct for 60 req/min)plugins/http/plugin_test.goTestRateLimitMiddlewareFactory_InvalidValues: zerorequestsPerHour, negativerequestsPerMinute, zeroburstSizeall fall back to defaults without panicking💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.